From a3ca460ebb9565e5b56e637803a5bd6770cb1631 Mon Sep 17 00:00:00 2001
From: Marco <marcomoa@hotmail.com>
Date: Wed, 13 Mar 2024 17:25:27 -0300
Subject: [PATCH] refactor: large seashell and move to core

---
 data-canary/lib/core/storages.lua             |  1 -
 .../scripts/actions/other/large_sea_shell.lua | 28 -----------------
 .../actions/objects/large_seashell.lua        | 30 +++++++++++++++++++
 3 files changed, 30 insertions(+), 29 deletions(-)
 delete mode 100644 data-canary/scripts/actions/other/large_sea_shell.lua
 create mode 100644 data/scripts/actions/objects/large_seashell.lua

diff --git a/data-canary/lib/core/storages.lua b/data-canary/lib/core/storages.lua
index 6aac447358a..3d9115f3aab 100644
--- a/data-canary/lib/core/storages.lua
+++ b/data-canary/lib/core/storages.lua
@@ -32,7 +32,6 @@ Storage = {
 		},
 	},
 
-	DelayLargeSeaShell = 30002,
 	Imbuement = 30004,
 }
 
diff --git a/data-canary/scripts/actions/other/large_sea_shell.lua b/data-canary/scripts/actions/other/large_sea_shell.lua
deleted file mode 100644
index b396bd70611..00000000000
--- a/data-canary/scripts/actions/other/large_sea_shell.lua
+++ /dev/null
@@ -1,28 +0,0 @@
-local largeSeaShell = Action()
-
-function largeSeaShell.onUse(player, item, fromPosition, target, toPosition, isHotkey)
-	if player:getStorageValue(Storage.DelayLargeSeaShell) <= os.time() then
-		local chance = math.random(100)
-		local msg = ""
-		if chance <= 16 then
-			doTargetCombatHealth(0, player, COMBAT_PHYSICALDAMAGE, -200, -200, CONST_ME_NONE)
-			msg = "Ouch! You squeezed your fingers."
-		elseif chance > 16 and chance <= 64 then
-			Game.createItem(math.random(281, 282), 1, player:getPosition())
-			msg = "You found a beautiful pearl."
-		else
-			msg = "Nothing is inside."
-		end
-		player:say(msg, TALKTYPE_MONSTER_SAY, false, player, item:getPosition())
-		item:transform(198)
-		item:decay()
-		player:setStorageValue(Storage.DelayLargeSeaShell, os.time() + 20 * 60 * 60)
-		item:getPosition():sendMagicEffect(CONST_ME_BUBBLES)
-	else
-		player:say("You have already opened a shell today.", TALKTYPE_MONSTER_SAY, false, player, item:getPosition())
-	end
-	return true
-end
-
-largeSeaShell:id(197)
-largeSeaShell:register()
diff --git a/data/scripts/actions/objects/large_seashell.lua b/data/scripts/actions/objects/large_seashell.lua
new file mode 100644
index 00000000000..c6d767146ec
--- /dev/null
+++ b/data/scripts/actions/objects/large_seashell.lua
@@ -0,0 +1,30 @@
+local largeSeashell = Action()
+
+function largeSeashell.onUse(player, item, fromPosition, target, toPosition, isHotkey)
+	if player:hasExhaustion("delay-large-seashell") then
+		player:say("You have already opened a shell today.", TALKTYPE_MONSTER_SAY, false, player, item:getPosition())
+		return true
+	end
+
+	local chance = math.random(100)
+	local message = "Nothing is inside."
+
+	if chance <= 16 then
+		doTargetCombatHealth(0, player, COMBAT_PHYSICALDAMAGE, -200, -200, CONST_ME_NONE)
+		message = "Ouch! You squeezed your fingers."
+	elseif chance > 16 and chance <= 64 then
+		Game.createItem(math.random(281, 282), 1, player:getPosition())
+		message = "You found a beautiful pearl."
+		player:addAchievementProgress("Shell Seeker", 100)
+	end
+
+	player:setExhaustion("delay-large-seashell", 20 * 60 * 60)
+	player:say(message, TALKTYPE_MONSTER_SAY, false, player, item:getPosition())
+	item:transform(198)
+	item:decay()
+	item:getPosition():sendMagicEffect(CONST_ME_BUBBLES)
+	return true
+end
+
+largeSeashell:id(197)
+largeSeashell:register()