Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getOriginalTermios error not propagated when called multiple times #16

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

joeycumines
Copy link

@joeycumines joeycumines commented Aug 11, 2023

I originally created this PR to address c-bata#266, but it looks like this fork already had a fix, which was for c-bata#228.

This just fixes a nearby code error that's unlikely to cause any actual issues.

I also addressed a staticcheck lint issue.

fbshipit-source-id: 84e7177
@joeycumines joeycumines deleted the upstream-elk-language branch August 13, 2023 23:00
@joeycumines joeycumines restored the upstream-elk-language branch August 13, 2023 23:00
@joeycumines joeycumines reopened this Aug 13, 2023
@joeycumines
Copy link
Author

@Verseth please review

@Verseth Verseth self-requested a review August 15, 2023 08:09
Copy link

@Verseth Verseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it and the terminal parameters are restored properly now.
The PR looks great, thanks for your contribution, I'll merge it and publish a new minor version

@Verseth Verseth merged commit 1ccfc35 into elk-language:master Aug 15, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants