-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interference analysis and generic safety requirements template for an ARM64 Linuxsystem #23
Conversation
Thanks very much for sharing these, Igor! To get them merged and available to a wider audience ASAP, I am going to propose that we don't review the content yet, but instead plan to add AsciiDoc conversions of the source material for each document in a future PR, so that we can propose and review future refinements and extensions. To get this PR merged, I would like to see the following changes:
I'm happy to help with all of this, and I will need to fix the problem with the CI first, as it is blocking merge. |
4d70ec4
to
7bb4de0
Compare
Done, with a caveat: I have left out the intended use, I would prefer to add that part together with the markdown. I think the documents can be anyway justified as 3rd party contribution without peer-review.
Done. |
7bb4de0
to
fe900cf
Compare
I've added to the README that the files are 3rd party, that should make it even more evident that they are not peer-reviewed within ELISA |
d8a405e
to
8abaed2
Compare
Create a "Contributions" directory with associated README, for hosting both 3rd-party work and derived peer-reviewed work. Signed-off-by: Igor Stoppa <istoppa@nvidia.com>
Declassified NVIDIA document, published under CC BY-SA 4.0 It refers to a generic ARM64 system running Linux and discusses interferences, from a safety perspective. There is a preamble detailing those parts of the HW/SW architecture which are relevant to the analysis. Signed-off-by: Igor Stoppa <istoppa@nvidia.com>
Declassified NVIDIA document, published under CC BY-SA 4.0 It refers to a generic ARM64 system running Linux and discusses interferences, from a safety perspective. It lists a non exhaustive set of safety requirements. Signed-off-by: Igor Stoppa <istoppa@nvidia.com>
8abaed2
to
e630fec
Compare
@reiterative it looks like the CI doesn't like the fact that I've used my work email in the Signed-off-by, even if it is registered as secondary email in this account. Anyways, this is it. If you do not see any error I might have missed, please accept the pull request. |
The DCO check complains that the author and signed-off-by email addresses differ. If you look at https://github.com/elisa-tech/wg-osep/commit/a733820b2fefa3052d6451fb62e30e5c8c611c31.patch, you will see the author is with the gmail address and sign off is with the nvidia address. Decide for one of the two and then keep it consistent. From a legal point of view, there is no difference. The DCO check also does not rely on github knowing to that they might be aliases for the same person. That should be easy to fix.
|
@bulwahn I had understood the "error". What I am saying is that it's an error based on an assumption that I think is not correct and instead it should rather be a warning. |
Okay, but why is it important to you that the author email is with gmail and the signed-off-by is with nvidia? Maybe there are better ways to achieve your intentions of the two email addresses differently. In the end, it is not clear how someone else would use this git metadata and if that then really achieves the intent you have. |
it is important to perform correct attribution, because it is fair to make it traceable in statistics, who sponsored the work - you can argue on the importance of this, but it's a fact that the sponsor is more obvious, in this way it is convenient to me to use this git account and email address. because it is what I regularly use, and also for tracking purposes it rules out any possibility of me accidentally leaking private information, since this work is done from outside the company firewall and vpn Notice also that I am not arguing on this check being in place, I'm just saying, if it helps having the warning, great. Now that it's confirmed there is no impersonation, please disregard the warning and merge the pull request, if there are no outstanding issues. Besides, AFAIK, the email address used to deliver the requests gets discarded. |
I think I understand your reasoning, Igor, and I do not see a problem in this case. I have set the DCO check to pass, and will now finish reading the documents. |
Sure, correct attribution is important. Just for your information: an alternative I have seen was to have the name set to "Firstname Lastname (Company) xyz@kernel.org" where kernel.org is of course not related to the Company, but just a general email account for kernel developers. Then, you also sign off with this identity, and the company affiliation is clear and the DCO check is clear and simple as well. As elisa-tech repository are just used for work in progress---final documentation goes into the linux-kernel repository---, there is nothing to worry about here anyway. |
Yes, I actually considered that, before sticking to the signed-off-by that the automation doesn't like, and then I rejected the idea. To me it looks really wrong to use a workaround (that's what it is), like the same person signing off twice, just to satisfy the shortcomings of an automatic check that should generate a warning instead of an error. |
@reiterative talking insted about real issues with the submission: I was not exactly sure of the way to represent urls pointing to the repo itself. In the .md files, each file is pointing to its respective seeding pdf, but the url might not be ok. I'd prefer to fix that, if needed, once the pull with the pdf is merged. |
Approving on the basis discussed in comments and in meetings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for merge as a contribution, as a basis for further review and derivation.
Initial pdf documents