Merge pull request #293 from eliashaeussler/fix/list-supported-models

[BUGFIX] List only supported models in `solver:list-models` command
eliashaeussler · Feb 8, 2025 · 0ec4ba0 · 0ec4ba0
2 parents 15a1dd0 + 62fe254
commit 0ec4ba0
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 5 deletions.
diff --git a/Classes/Command/ListModelsCommand.php b/Classes/Command/ListModelsCommand.php
@@ -65,7 +65,7 @@ protected function execute(Console\Input\InputInterface $input, Console\Output\O
             $io->title('Available GPT models');
 
             // Filter by GPT models
-            $modelListResponse = \array_filter($modelListResponse, $this->isGPTModel(...));
+            $modelListResponse = \array_filter($modelListResponse, $this->isSupportedModel(...));
         }
 
         // Map responses to model IDs
@@ -86,9 +86,18 @@ protected function execute(Console\Input\InputInterface $input, Console\Output\O
         return self::SUCCESS;
     }
 
-    private function isGPTModel(Responses\Models\RetrieveResponse $response): bool
+    /**
+     * @see https://platform.openai.com/docs/models#model-endpoint-compatibility
+     */
+    private function isSupportedModel(Responses\Models\RetrieveResponse $response): bool
     {
-        return \str_starts_with(\strtolower($response->id), 'gpt-');
+        $identifier = \strtolower($response->id);
+
+        if (!\str_starts_with($identifier, 'gpt-') && !\str_starts_with($identifier, 'chatgpt-')) {
+            return false;
+        }
+
+        return !\str_contains($identifier, '-realtime') && !\str_contains($identifier, '-audio');
     }
 
     private function decorateModel(Responses\Models\RetrieveResponse $response): string

diff --git a/Resources/Private/Frontend/package-lock.json b/Resources/Private/Frontend/package-lock.json
diff --git a/Tests/Unit/Command/ListModelsCommandTest.php b/Tests/Unit/Command/ListModelsCommandTest.php
@@ -63,7 +63,7 @@ protected function setUp(): void
     }
 
     #[Framework\Attributes\Test]
-    public function executeListsAllGPTModels(): void
+    public function executeListsAllSupportedModels(): void
     {
         $response = new Psr7\Response(headers: [
             'Content-Type' => 'application/json',
@@ -88,6 +88,13 @@ public function executeListsAllGPTModels(): void
             ]),
             $this->commandTester->getDisplay(),
         );
+        self::assertStringNotContainsString(
+            \implode(PHP_EOL, [
+                ' * gpt-4o-mini-audio-preview (created at 16/12/2024)',
+                ' * gpt-4o-realtime-preview (created at 30/09/2024)',
+            ]),
+            $this->commandTester->getDisplay(),
+        );
         self::assertStringContainsString(
             \implode(PHP_EOL, [
                 ' * gpt-3.5 (created at 28/02/2023)',
@@ -124,6 +131,8 @@ public function executeListsAllAvailableModels(): void
                 ' * foo-1 (created at 01/01/2023)',
                 ' * gpt-3.5 (created at 28/02/2023)',
                 ' * gpt-3.5-turbo-0301 (created at 01/03/2023)',
+                ' * gpt-4o-mini-audio-preview (created at 16/12/2024)',
+                ' * gpt-4o-realtime-preview (created at 30/09/2024)',
             ]),
             $this->commandTester->getDisplay(),
         );
@@ -188,6 +197,18 @@ private function createListResponse(): array
                     'created' => 1641038400,
                     ...$defaults,
                 ],
+                [
+                    'id' => 'gpt-4o-realtime-preview',
+                    // 30/09/2024
+                    'created' => 1727654400,
+                    ...$defaults,
+                ],
+                [
+                    'id' => 'gpt-4o-mini-audio-preview',
+                    // 16/12/2024
+                    'created' => 1734307200,
+                    ...$defaults,
+                ],
             ],
         ];
     }