Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BackgroundSource: Keep a reference to the monitor manager #1767

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

tintou
Copy link
Member

@tintou tintou commented Sep 29, 2023

Also use a GLib.HashTable instead of Gee.HashMap as it is enough for here.

@tintou tintou requested a review from lenemter September 29, 2023 08:49
Also use a GLib.HashTable instead of Gee.HashMap as it is enough for here.
@tintou tintou force-pushed the tintou/backgroundsource branch from ae6fe55 to 2c8f786 Compare September 29, 2023 08:52
Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for this! I guess this should fix #1764, shouldn't it?

@tintou
Copy link
Member Author

tintou commented Sep 29, 2023

It should theoretically, but I haven't tested it

Make sure that we will have the same object on destroy.
@tintou tintou force-pushed the tintou/backgroundsource branch from 2c8f786 to 5a10635 Compare September 29, 2023 08:53
@lenemter lenemter merged commit f771b2a into master Sep 29, 2023
@lenemter lenemter deleted the tintou/backgroundsource branch September 29, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants