Round corners of workspaces in multitasking view #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you zoom in a bunch you can see something is drawing a square here
|
|
@danirabbit I increased outline border radius, does it look better on your screen? |
|
@lenemter I think what's actually happening is that in the cairo rounded rectangle function the corners are drawn offset by like a half pixel which gives that weird aliasing. Gonna try to see if I can figure out how to fix it |
|
@lenemter okay I don't know enough about cairo to fix this lol. But I think just making it 1px larger is what it should be and not 3px larger |
|
Actually it should be smaller right? Like it doesn't make sense lol something is weird here |
danirabbit
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1545