Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix block comment toggling for empty lines #1468

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Fix block comment toggling for empty lines #1468

merged 2 commits into from
Oct 9, 2024

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Oct 7, 2024 •
edited
Loading

Fixes #1466

  • Ignore empty (all whitespace) lines
  • Only add/remove end tag if start tag as been added/removed

The existing code could do with some simplifying and commenting but that is left for another PR.

@jeremypw jeremypw changed the title Fix comment toggling for markdown empty lines Fix block comment toggling for empty lines Oct 7, 2024
@jeremypw jeremypw marked this pull request as ready for review October 7, 2024 15:04
@jeremypw jeremypw requested a review from a team October 7, 2024 15:04
zeebok
zeebok approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This did the trick!

@jeremypw jeremypw merged commit f49d00d into master Oct 9, 2024
6 checks passed
@jeremypw jeremypw deleted the jeremypw/fix-markdown-comment branch October 9, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeebok zeebok zeebok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

improper markdown auto comment on empty lines
2 participants
@jeremypw @zeebok