Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GTK4 Prep] Use actions for New Window menu item in FileItem #1456

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

colinkiama
Copy link
Member

Part of of "Replace Gtk.MenuItem with GLib.MenuModel" task in #1157

After this, the none of menu items in FileView context menus will be activated using the activate signal. The switch to GLib.MenuModel will be simple after this.

@colinkiama colinkiama requested a review from a team July 25, 2024 19:01
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very straightforward 👍

@danirabbit danirabbit merged commit 7194d09 into master Jul 25, 2024
6 checks passed
@danirabbit danirabbit deleted the colinkiama/use-new-window-action-in-file-view branch July 25, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants