[GTK4 Prep] Move External App Actions Logic To Utils #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
requested changes
Jul 24, 2024
colinkiama
force-pushed
the
colinkiama/move-external-app-actions-logic-to-utils
branch
from
b57bf1a to
f1d903e
Compare
|
I've made new changes that should resolve all the issues now. |
danirabbit
reviewed
Jul 24, 2024
src/Utils.vala
Outdated
| var menu = new Gtk.Menu (); | ||
|
|
||
| try { | ||
| var contracts = Granite.Services.ContractorProxy.get_contracts_by_mime (file_type); |
There was a problem hiding this comment.
Should this be https://valadoc.org/granite-7/Granite.Services.ContractorProxy.get_contracts_for_file.html so we don't have to manually get file type?
There was a problem hiding this comment.
Yeah. That makes the code more concise. Thanks!
danirabbit
reviewed
Jul 24, 2024
src/Utils.vala
Outdated
| var file = GLib.File.new_for_path (path); | ||
|
|
||
| try { | ||
| var contracts = Granite.Services.ContractorProxy.get_contracts_by_mime (file_type); |
There was a problem hiding this comment.
This has been updated now too.
danirabbit
deleted the
colinkiama/move-external-app-actions-logic-to-utils
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of of "Replace Gtk.MenuItem with GLib.MenuModel" task in #1157