Jeremypw/fix cancel folder creation #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1436
The dummy entry for an empty folder gets removed during new file creation/renaming but was not being replaced if the file never got created resulting the parent not being visible. This PR fixes that.
Also fixes issue in OS8 where an empty file no longer has a text content type so was not being shown in the sidebar.
To test 1:
Escmasterthe project folder disappears. In this PR it remains expanded with a dummy itemTo test 2:
Entermasterno addition item is shown (although it opens as a document). In this PR the new empty file is show in the sidebar.