Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PreferencesDialog: make whitespace strings consistent #1451

Merged
merged 2 commits into from
Jul 13, 2024

Conversation

davidmhewitt
Copy link
Member

We use "whitespace" here, so this should maybe be the same? Or maybe that one should be changed? Or maybe they should both have a hyphen? 😆

But I think they should at least be consistent.

general_box.add (new SettingSwitch (_("Strip trailing whitespace on save"), "strip-trailing-on-save"));

@danirabbit
Copy link
Member

danirabbit commented Jul 13, 2024

Looked around to try to find some kind of more definitive answer or styleguide here but the best I could find is that generally "whitespace" (as a single word) can refer to any character that is not visible (like tab or space) whereas "white space" refers more generally to the concept of leaving a blank space. So single word is probably appropriate here since we're talking making whitespace characters visible and stripping trailing whitespace characters

@danirabbit danirabbit enabled auto-merge (squash) July 13, 2024 16:55
@danirabbit danirabbit merged commit 1ce15e1 into master Jul 13, 2024
6 checks passed
@danirabbit danirabbit deleted the davidmhewitt/whitespace-strings branch July 13, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants