[dev] fix linting

electrovir · Dec 10, 2024 · 9bf43cc · 9bf43cc
1 parent 925a5d1
commit 9bf43cc
Show file tree

Hide file tree

Showing 7 changed files with 6 additions and 12 deletions.
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -17,6 +17,8 @@ export default [
              * Turn off or on specific rules. See {@link defineEslintConfig} for which plugins are
              * already enabled.
              */
+            'sonarjs/no-unused-vars': 'off',
+            'sonarjs/prefer-regexp-exec': 'off',
         },
     },
 ];
diff --git a/packages/element-vir/src/declarative-element/directives/async-prop.ts b/packages/element-vir/src/declarative-element/directives/async-prop.ts
@@ -30,7 +30,6 @@ export type AsyncProp<Value, Params> = Omit<
  *
  * @category Internal
  */
-// eslint-disable-next-line sonarjs/no-redeclare
 export const AsyncProp: Constructor<
     AsyncProp<unknown, unknown>,
     ConstructorParameters<typeof InternalAsyncPropClass<unknown, unknown>>

diff --git a/packages/element-vir/src/declarative-element/properties/property-proxy.ts b/packages/element-vir/src/declarative-element/properties/property-proxy.ts
@@ -61,7 +61,6 @@ export function createElementPropertyProxy<PropertyInitGeneric extends PropertyI
     const elementAsProps = element as DeclarativeElement & PropertyInitGeneric;
 
     function verifyProperty(propertyKey: PropertyKey) {
-        // eslint-disable-next-line sonarjs/no-selector-parameter
         if (shouldAlreadyExist) {
             assertValidPropertyName(propertyKey, element, element.tagName);
         } else {

diff --git a/packages/vira/src/elements/dropdown/dropdown-helpers.ts b/packages/vira/src/elements/dropdown/dropdown-helpers.ts
@@ -67,7 +67,6 @@ export function createNewSelection(
     currentSelection: ReadonlyArray<PropertyKey>,
     isMultiSelect: boolean,
 ): PropertyKey[] {
-    // eslint-disable-next-line sonarjs/no-selector-parameter
     if (isMultiSelect) {
         return currentSelection.includes(id)
             ? currentSelection.filter((entry) => entry !== id)

diff --git a/packages/vira/src/elements/vira-input.element.ts b/packages/vira/src/elements/vira-input.element.ts
@@ -74,9 +74,9 @@ export const ViraInput = defineViraElement<
         'vira-input-clear-button-hover-color': '#ff0000',
         'vira-input-clear-button-active-color': '#b30000',
 
-        // eslint-disable-next-line sonarjs/no-hardcoded-credentials
+        // eslint-disable-next-line sonarjs/no-hardcoded-passwords
         'vira-input-show-password-button-hover-color': '#0a89ff',
-        // eslint-disable-next-line sonarjs/no-hardcoded-credentials
+        // eslint-disable-next-line sonarjs/no-hardcoded-passwords
         'vira-input-show-password-button-active-color': '#0261ba',
 
         'vira-input-padding-horizontal': '10px',

diff --git a/packages/vira/src/re-exports/colorjs-io.ts b/packages/vira/src/re-exports/colorjs-io.ts
@@ -16,5 +16,4 @@ export type Color = typeof ColorImport;
  *
  * @category Internal
  */
-// eslint-disable-next-line sonarjs/no-redeclare
 export const Color: Color = ColorImport;
diff --git a/packages/vira/src/styles/color.ts b/packages/vira/src/styles/color.ts
@@ -1,4 +1,4 @@
-import {wrapInTry} from '@augment-vir/common';
+import {stringify} from '@augment-vir/common';
 import {Format} from 'colorjs.io/types/src/space';
 import {Color, ColorTypes} from '../re-exports/colorjs-io.js';
 
@@ -14,11 +14,7 @@ export function getAssertedValidColor(input: ColorTypes | undefined) {
         }
         return new Color(input);
     } catch {
-        const stringInput = String(input);
-        const inputForMessage: string = stringInput.toLowerCase().match(/\[\s*object\s+object\s*\]/)
-            ? wrapInTry(() => JSON.stringify(input), {fallbackValue: stringInput})
-            : stringInput;
-        throw new Error(`Invalid color: ${inputForMessage}`);
+        throw new Error(`Invalid color: ${stringify(input)}`);
     }
 }