refactor: rename a method for clarity

electron · Aug 20, 2021 · 1d2a9cb · 1d2a9cb
1 parent 102229e
commit 1d2a9cb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/module-rebuilder.ts b/src/module-rebuilder.ts
@@ -116,7 +116,7 @@ export class ModuleRebuilder {
     return binary?.napi_versions;
   }
 
-  async getPrebuildRuntimeArgs(): Promise<string[]> {
+  async getPrebuildInstallRuntimeArgs(): Promise<string[]> {
     const napiVersion = await this.getNapiVersion();
     if (napiVersion) {
       return [
@@ -375,7 +375,7 @@ export class ModuleRebuilder {
         `--arch=${this.rebuilder.arch}`,
         `--platform=${process.platform}`,
         `--tag-prefix=${this.rebuilder.prebuildTagPrefix}`,
-        ...await this.getPrebuildRuntimeArgs(),
+        ...await this.getPrebuildInstallRuntimeArgs(),
       ],
       {
         cwd: this.modulePath,

diff --git a/test/rebuild.ts b/test/rebuild.ts
@@ -102,7 +102,7 @@ describe('rebuilder', () => {
       const modulePath = path.join(testModulePath, 'node_modules', 'farmhash');
       const modRebuilder = new ModuleRebuilder(rebuilder, modulePath);
       expect(await modRebuilder.getNapiVersion()).to.equal(3);
-      expect(await modRebuilder.getPrebuildRuntimeArgs()).to.deep.equal([
+      expect(await modRebuilder.getPrebuildInstallRuntimeArgs()).to.deep.equal([
         '--runtime=napi',
         `--target=3`,
       ])