Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: strictVerify not working with true value #345

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: strictVerify not working with true value #345

wants to merge 1 commit into from

Conversation

t3chguy
Copy link

@t3chguy t3chguy commented Feb 3, 2025

And extend it to support string-specified restrictions

Fixes #344

@t3chguy
Fix strictVerify not working with true value
0833b37 
And extend it to support string-specified restrictions
@t3chguy t3chguy mentioned this pull request Feb 3, 2025
Open
@t3chguy t3chguy marked this pull request as ready for review February 3, 2025 21:34
@t3chguy t3chguy requested a review from a team as a code owner February 3, 2025 21:34
@erickzhao erickzhao self-requested a review February 3, 2025 22:11
BlackHole1
BlackHole1 approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@BlackHole1 BlackHole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlackHole1 BlackHole1 BlackHole1 approved these changes

@erickzhao erickzhao Awaiting requested review from erickzhao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

strictVerify types seem wrong
2 participants
@t3chguy @BlackHole1