feat(web): enable 1 hour app delay using feature flag #7805
+38
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbdietrich @VIKTORVAV99 Any early thoughts on this? Also do you know why the labeler is failing? |
|
The labeler you can ignore… |
|
@silkeholmebonnen is this ready for review or is it missing some part? |
It is ready for review, but the backend PR should be merged before this one |
|
Feel free to request my review on both if you need it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
GMM-406
Description
This PR uses the feature flag 1-hour-app-delay to conditionally reduce app delay to 1 hour. It adds the parameter to the backend request to get the correct data with only 1 hour delay. This only works when using the modified app backend from this PR. So this PR should not be merged until the backend PR has been merged.
Preview
Screen.Recording.2025-02-05.at.11.35.51.mov
Double check
pnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.