Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): Update information copy and CTAs #7568
feat(web): Update information copy and CTAs #7568
Changes from 5 commits
ff8857b
5764f77
5d8f4f4
d82d82b
181739f
3f6a4fd
28583e7
8f9b71d
11126fc
886e787
20fbd71
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Looking for forecast data" and the CTA feel a little disconnected. Maybe they could go on the same line? 🤔
![Screenshot 2024-12-19 at 10 53 22](https://private-user-images.githubusercontent.com/7953060/397331253-7689ccba-0c62-4f43-8857-c8f653cd3763.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1OTY4OTIsIm5iZiI6MTczOTU5NjU5MiwicGF0aCI6Ii83OTUzMDYwLzM5NzMzMTI1My03Njg5Y2NiYS0wYzYyLTRmNDMtODg1Ny1jOGY2NTNjZDM3NjMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTVUMDUxNjMyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NTU3YTViYjFlZjBkMTY0M2Q4NTM4MGYzNDc4YmE0NDc3OGM5MjVkMjBiM2EyNWE0NWFlMzMwNjIyMjU1ZjZhYiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.RKo7sVy0AIjpJ0LyHW5eStic3aBApt0VAK_knE2AwZ0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, this was quite a speculative change, we can remove it or try on the same line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small tweak suggestions to the grammar for clarity:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I wonder if we should link to the commercial website here (at least for the time being). "To find out more..." etc etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or just link the words "Electricity Maps" to the commercial website?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try the link! I'm a little bit cautious to change the copy for this one in particular as it's copy pasta from else where (job posting I believe) and having them drift slightly might be confusing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks great!
![image](https://private-user-images.githubusercontent.com/18622768/397600825-97c22cab-799e-43e2-94ce-df59e88c83db.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1OTY4OTIsIm5iZiI6MTczOTU5NjU5MiwicGF0aCI6Ii8xODYyMjc2OC8zOTc2MDA4MjUtOTdjMjJjYWItNzk5ZS00M2UyLTk0Y2UtZGY1OWU4OGM4M2RiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDA1MTYzMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY2MjNjMDdhOTgwMjBmMjEyOGQ3OWJhOTA0YTIwNjY2MjBmYTBkZTM2ZTA1ZjgzZDljZGRmZWI4MmQ3MTNiYzYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.2M9IeIEswSQd99Wg3bU8zyhHKM8-CqaWxq-Ge460Cyc)
Thanks for the suggestion!