refactor(us-mida-pjm): upgrade US-MIDA-PJM parser with event classes #6635
Conversation
…refactor to use event classes
github-actions
bot
added
parser
python
| if target_datetime is not None: | ||
| raise NotImplementedError("This parser is not yet able to parse past dates") | ||
| raise ParserException( | ||
| PARSER, | ||
| "This parser is not yet able to parse historical data", | ||
| sorted_zone_keys, | ||
| ) |
There was a problem hiding this comment.
This might be a blocker for the above though...
We generally prefer parsers that can fetch historical data (even if it's delayed) over realtime only parsers.
However in the future we might support using multiple parsers for the same data types then this would be really valuable.
Regardless I'll check with the team.
|
Perfect - thank you so much @VIKTORVAV99! no rush on my side |
|
Sorry for kind of forgetting about this PR! @amv213 is this something you are still interested in doing otherwise I can solve the merge conflicts myself and get this merged. |
|
No worries @VIKTORVAV99 !! Very happy for you to hop on this branch and take over 🙌🏽 Thanks! |
Thanks! I'll get this merged in the next few days then 🙂 |
Issue
#6011
Description
This PR upgrades the US-MIDA-PJM parser to use event classes.
I have also fixed the
.fetch_exchange()function, and expanded it to support all possible neighbouring exchanges. I also fixed a small bug that I found.Double check
poetry run test_parser "zone_key"pnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.