Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update sync plugin to work with the latest Electric sync server #531

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

samwillis
Copy link
Collaborator

This fix is something of a stop gap untill we make some larger changes to the plugin and bring in multi table/shape sync.

@copiltembel
Copy link
Collaborator

copiltembel commented Feb 11, 2025

@samwillis I've pushed a stylecheck fix but some tests are failing on CI due to offset property missing in Message.

Error: packages/pglite-sync typecheck: test/sync.test.ts(558,7): error TS2353: Object literal may only specify known properties, and 'offset' does not exist in type 'Message'.

@samwillis
Copy link
Collaborator Author

samwillis commented Feb 12, 2025

@copiltembel 🤦‍♂️ I had forgotten to run pnpm typecheck before pushing. Fixed now, just removed the offending props.

Ready for a final review.

Copy link
Collaborator

@copiltembel copiltembel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@samwillis samwillis merged commit b3640ee into main Feb 12, 2025
8 checks passed
@samwillis samwillis deleted the samwillis/update-sync-plugin branch February 12, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants