fix(redis example): update for partial updates #1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for electric-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
samwillis
approved these changes
Oct 3, 2024
| // Loop through each message and make writes to the Redis hash for action messages | ||
| messages.forEach((message) => { | ||
| if (!isChangeMessage(message)) return | ||
| console.log(`message`, message) |
There was a problem hiding this comment.
Left over console.log from debugging?
There was a problem hiding this comment.
Oh I left it there on purpose actually as when playing with it it's nice to see the message log get outputted. For a production version yeah you wouldn't want it but I think it's nice for an example.
Comment on lines
+41
to
+42
| // FIXME The Redis docs suggest only sending 10k commands at a time | ||
| // to avoid excess memory usage buffering commands. |
There was a problem hiding this comment.
Worth creating an issue for?
There was a problem hiding this comment.
Eh no. It's a very low priority for an example. It's more a note for someone taking this into production. Perhaps the first to use this at scale can update it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1789