feat (client): extensible value type for use with custom parsers #1791
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the types of our client to enable users to extend the
Value
type. This is needed when using custom parsers.For example, the parser below used to throw a type error because
Date
is not aValue
(whereValue
is the type of base SQL values):With this PR, we can now write this parser as:
And an example usage of this parser with the
ShapeStream
:Note that this would throw an error as
Date
is not a type that occurs in the row: