fix: Completely disable ReplicationClient's auto-reconnection logic #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm suspecting this is the reason for some hard-to-reproduce transient errors we've seen in tests.
…AL offsets This used to be necessary before the updated handling of WAL offsets was committed in e9a05f8
If we see transient errors caused by the violation of our assumptions about WAL offset's monotonic growth, this should have debug that.
alco
force-pushed
the
alco/logical-replication-lsn
branch
from
7a9079b
to
3f219cb
Compare
alco
changed the title
|
Moved to electric-sql/electric#1486. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes to make some types of test failure less likely.
Recent example - https://github.com/electric-sql/electric-next/actions/runs/10256059321/job/28374360808?pr=254. These happen occasionally but are impossible to reproduce deliberately. I suspect the issue is related to the use of persistent slot and auto-reconnection logic that results Postgres delivering a logical message with a lower WAL offset than the one in
ReplicationClient's state.