Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #66: force conversion to string prior to JSON serialization #67

Closed
wants to merge 9 commits into from
Closed

Conversation

jayhale
Copy link

@jayhale jayhale commented Sep 18, 2017

Fixes #66.

martey and others added 3 commits July 17, 2017 18:54
Allow setting the Reply-To header through the "reply_to" attribute or
by setting extra headers. Support both email address and "name <email>".
@codecov-io
Copy link

codecov-io commented Sep 18, 2017

Codecov Report

Merging #67 into master will increase coverage by 4.47%.
The diff coverage is 78.94%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #67      +/-   ##
=========================================
+ Coverage   60.22%   64.7%   +4.47%     
=========================================
  Files           1       1              
  Lines          88     102      +14     
  Branches       22      27       +5     
=========================================
+ Hits           53      66      +13     
  Misses         29      29              
- Partials        6       7       +1
Impacted Files Coverage Δ
sgbackend/mail.py 64.7% <78.94%> (+4.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 476bfbe...838406e. Read the comment docs.

Add support for Reply-To.
@andriisoldatenko
Copy link
Collaborator

andriisoldatenko commented Sep 21, 2017

@jayhale

  • need tests.
  • need docs.

@jayhale jayhale changed the title Fix #66: force conversation to string prior to JSON serialization Fix #66: force conversion to string prior to JSON serialization Sep 21, 2017
@jayhale
Copy link
Author

jayhale commented Sep 25, 2017

@andriisoldatenko thanks. I added the tests and rebased to current master. Is there a doc template I missed? I just included the string in the function def as is habit.

@jayhale jayhale closed this Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lacking compatibility with lazy-translated strings
4 participants