Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle the reply_to header value #51

Closed
wants to merge 2 commits into from

Conversation

MickaelBergem
Copy link

See #34 and #50 for the details.

@andriisoldatenko
Copy link
Collaborator

@MickaelBergem Thanks for creating patch. Can you please add unit tests?

@kevin-brown
Copy link

kevin-brown commented Feb 7, 2017

So, the Reply-To header supports setting multiple addresses, and Django handles this by making reply_to a tuple. SendGrid actually supports multiple Reply-To addresses as well if you set the header.

http://stackoverflow.com/q/15820418/359284

Unfortunately it looks like the web API does not handle multiple Reply-To addresses. I'm not sure if you know of a good way to get around this, or if it should just be documented that the SendGrid plugin doesn't support multiple addresses.

@vinitkumar
Copy link

@MickaelBergem does your patch work?

@jancsarc
Copy link

It isn't working for me so far...

@MickaelBergem
Copy link
Author

@vinitkumar @jancsarc sorry guys I lacked time on this and never provided the unit tests, and gave up using my fork, don't remember if I was able to use it successfully.

Feel free to test / post the error you are getting here / take over the fixing of this bug :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants