Added control for the nil request #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpatlasov
reviewed
Jul 20, 2023
|
/lgtm |
mpatlasov
approved these changes
Jul 21, 2023
neild
reviewed
Jul 25, 2023
https.go
Outdated
| @@ -246,7 +246,11 @@ func (proxy *ProxyHttpServer) handleHttps(w http.ResponseWriter, r *http.Request | |||
| return | |||
| } | |||
| if err != nil { | |||
| ctx.Warnf("Illegal URL %s", "https://"+r.Host+req.URL.Path) | |||
| if req != nil { | |||
There was a problem hiding this comment.
Drive by review: Should this be if req.URL != nil? If req is nil, then I'd expect isWebSocketRequest above to panic.
There was a problem hiding this comment.
Yes, good catch. I've changed to if req.URL != nil instead.
|
Any plans to merge this? |
We need a maintainer approval. |
mpatlasov
added a commit
to mpatlasov/aws-ebs-csi-driver
that referenced
this pull request
Aug 24, 2023
…491) ``` $ go get -u github.com/elazarl/goproxy@f99041a5c0273fcf6a144498b458a630585872f; go mod tidy; go mod vendor ``` where `f99041a5c` is commit-id corresponding to elazarl/goproxy#507 which resolved CVE-2023-37788
mpatlasov
added a commit
to mpatlasov/aws-ebs-csi-driver
that referenced
this pull request
Aug 24, 2023
The patch to be dropped on the nearest CSI driver rebase (upstream aws-ebs CSI driver does not depend on goproxy since v1.19.0). The PR removing goproxy deps upstream: kubernetes-sigs#1602 The content of this patch resulted from: ``` $ go get -u github.com/elazarl/goproxy@f99041a5c0273fcf6a144498b458a630585872f; go mod tidy; go mod vendor ``` where `f99041a5c` is commit-id corresponding to elazarl/goproxy#507 which resolved CVE-2023-37788
mpatlasov
added a commit
to mpatlasov/vmware-vsphere-csi-driver
that referenced
this pull request
Aug 24, 2023
The content of this patch resulted from: ``` $ go get -u github.com/elazarl/goproxy@f99041a5c0273fcf6a144498b458a630585872f; go mod tidy ``` where `f99041a5c` is commit-id corresponding to elazarl/goproxy#507 which resolved CVE-2023-37788
k8s-ci-robot
pushed a commit
to kubernetes-sigs/vsphere-csi-driver
that referenced
this pull request
Aug 28, 2023
The content of this patch resulted from: ``` $ go get -u github.com/elazarl/goproxy@f99041a5c0273fcf6a144498b458a630585872f; go mod tidy ``` where `f99041a5c` is commit-id corresponding to elazarl/goproxy#507 which resolved CVE-2023-37788
chethanv28
pushed a commit
to chethanv28/vsphere-csi-driver
that referenced
this pull request
Sep 1, 2023
…s#2511) The content of this patch resulted from: ``` $ go get -u github.com/elazarl/goproxy@f99041a5c0273fcf6a144498b458a630585872f; go mod tidy ``` where `f99041a5c` is commit-id corresponding to elazarl/goproxy#507 which resolved CVE-2023-37788
k8s-ci-robot
pushed a commit
to kubernetes-sigs/vsphere-csi-driver
that referenced
this pull request
Sep 1, 2023
The content of this patch resulted from: ``` $ go get -u github.com/elazarl/goproxy@f99041a5c0273fcf6a144498b458a630585872f; go mod tidy ``` where `f99041a5c` is commit-id corresponding to elazarl/goproxy#507 which resolved CVE-2023-37788 Co-authored-by: Maxim Patlasov <mpt@redhat.com>
mpatlasov
added a commit
to mpatlasov/vmware-vsphere-csi-driver
that referenced
this pull request
Oct 19, 2023
…VE-2023-37788 > The content of this patch resulted from: ``` $ go get -u github.com/elazarl/goproxy@f99041a5c0273fcf6a144498b458a630585872f; go mod tidy; go mod vendor ``` > where `f99041a5c` is commit-id corresponding to elazarl/goproxy#507 which resolved CVE-2023-37788
mpatlasov
added a commit
to mpatlasov/vmware-vsphere-csi-driver
that referenced
this pull request
Oct 19, 2023
…VE-2023-37788 The content of this patch resulted from: ``` $ go get -u github.com/elazarl/goproxy@f99041a5c0273fcf6a144498b458a630585872f; go mod tidy; go mod vendor ``` where `f99041a5c` is commit-id corresponding to elazarl/goproxy#507 which resolved CVE-2023-37788
mpatlasov
added a commit
to mpatlasov/vmware-vsphere-csi-driver
that referenced
this pull request
Oct 19, 2023
…VE-2023-37788 The content of this patch resulted from: ``` $ go get -u github.com/elazarl/goproxy@f99041a5c0273fcf6a144498b458a630585872f; go mod tidy; go mod vendor ``` where `f99041a5c` is commit-id corresponding to elazarl/goproxy#507 which resolved CVE-2023-37788
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is to prevent Goproxy server crashes if the request cannot be parsed in line https://github.com/elazarl/goproxy/blob/master/https.go#L234 then logged in line https://github.com/elazarl/goproxy/blob/master/https.go#L249 when proxy is in MITM mode.
Fixes #502