[WIP] - Improve performance #212173
[WIP] - Improve performance #212173
Conversation
michaelolo24
added
performance
release_note:skip
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
| securityLayout: { getPluginWrapper }, | ||
| }, | ||
| } = useKibana(); | ||
| export const PluginTemplateWrapper: FC<KibanaPageTemplateProps> = React.memo( |
There was a problem hiding this comment.
Prevent multiple re-renders of the UI
| @@ -67,10 +66,10 @@ export const useSourcererDataView = ( | |||
| if (selectedDataView == null || missingPatterns.length > 0) { | |||
| // old way of fetching indices, legacy timeline | |||
| setLegacyPatterns(selectedPatterns); | |||
| } else { | |||
| } else if (legacyPatterns.length > 0) { | |||
There was a problem hiding this comment.
A new [] was being created on every run of this hook, thereby updating state, thereby re-rendering every component where this hook is being called
| @@ -37,7 +40,9 @@ export const UnifiedTimelineBody = (props: UnifiedTimelineBodyProps) => { | |||
| leadingControlColumns, | |||
| onUpdatePageIndex, | |||
| } = props; | |||
|
|
|||
| const dataView = useGetScopedSourcererDataView({ | |||
There was a problem hiding this comment.
removed withDataView in favor of this call as it only happens in one place in the tree since the only other location it was used was the child component UnifiedTimeline here
| <HideShowContainer | ||
| $isVisible={TimelineTabs.query === activeTimelineTab} | ||
| data-test-subj={`timeline-tab-content-${TimelineTabs.query}`} | ||
| <OnDemandRenderer |
There was a problem hiding this comment.
Only load the components when you click on the tab, but it remains rendered after first load
| * every time timeline is closed and re-opened after the first interaction. | ||
| */ | ||
|
|
||
| const getTimelineShowStatus = useMemo(() => getTimelineShowStatusByIdSelector(), []); |
There was a problem hiding this comment.
Not necessary anymore as the entire tabs are now being rendered on demand
| const categoryBrowserFields = Object.values(browserFields[categoryId]?.fields ?? {}); | ||
| if (categoryBrowserFields.length > 0) { | ||
| fieldItemsAcc.push( |
There was a problem hiding this comment.
At scale this was crashing the browser (tested with 500k fields):
michaelolo24
force-pushed
the
improve-security-solution-performance
branch
from
6f23250 to
f03d9db
Compare
|
/ci |
michaelolo24
force-pushed
the
improve-security-solution-performance
branch
from
62d9a8b to
cd514e9
Compare
|
/ci |
|
/ci |
💔 Build Failed
Failed CI StepsHistory
|
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.