[9.0] [scout] validate config has tests before starting servers (#211918) #211941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1918) ## Summary There is no need to start servers (~1.5 min run time) if there are no tests matching filters or maybe config itself has all tests skipped. This PR uses Playwright cli with `--list` flag to quickly validate playwright config and exit with status code `2` (`1` is reserved for errors during servers start or test failures). it also useful to know in advance how many tests were about to run: case 1: tests found ``` $ node scripts/scout.js run-tests --config x-pack/platform/plugins/private/discover_enhanced/ui_tests/parallel.playwright.config.ts --serverless=security info scout: Test server configuration saved at /Users/dmle/github/kibana/.scout/servers/local.json info scout: Validate Playwright config has tests info scout: Total: 5 tests in 2 files info Verifying Docker is installed. │ info Docker version 20.10.14, build a224086349 ... ``` case 2: no tests found ``` $ node scripts/scout.js run-tests --config x-pack/solutions/observability/plugins/observability_onboarding/ui_tests/playwright.config.ts --stateful info scout: Test server configuration saved at /Users/dmle/github/kibana/.scout/servers/local.json info scout: Validate Playwright config has tests ERROR scout: No tests found in [x-pack/solutions/observability/plugins/observability_onboarding/ui_tests/playwright.config.ts] ``` (cherry picked from commit 30c4275)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💚 Build Succeeded
Metrics [docs]
cc @dmlemeshko |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.0:Questions ?
Please refer to the Backport tool documentation