Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.0] [Security Solution] Fix flyout history flickering (#211662) #211937

Merged
merged 1 commit into from
Feb 20, 2025
Merged

[9.0] [Security Solution] Fix flyout history flickering (#211662) #211937

merged 1 commit into from
Feb 20, 2025

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 9.0:

Questions ?

Please refer to the Backport tool documentation

@christineweng
[Security Solution] Fix flyout history flickering (elastic#211662)
a0ae83c 
## Summary

This PR fixed a flickering issue in flyout history

**Before**
`Event details` is shown and then replaced by actual alert title

https://github.com/user-attachments/assets/edb1e6eb-c290-4cdc-a5f9-3f270a26a58b

**After**
Show a loading skeleton text while fetching rule name

![image](https://github.com/user-attachments/assets/eb20892d-7bbc-4687-bf11-a9cbc65288d3)

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit e2730f7)
@kibanamachine kibanamachine enabled auto-merge (squash) February 20, 2025 17:12
@kibanamachine kibanamachine mentioned this pull request Feb 20, 2025
Merged
2 tasks
@kibanamachine kibanamachine merged commit f3cbcc0 into elastic:9.0 Feb 20, 2025
13 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #40 / dashboard app - group 3 dashboard panel copy to "after all" hook for "it always appends new panels instead of overwriting"
  • [job] [logs] FTR Configs #40 / dashboard app - group 3 dashboard panel copy to copies a panel to an existing dashboard

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.8MB 8.8MB +210.0B

cc @christineweng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@christineweng christineweng

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibanamachine @elasticmachine @christineweng