Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.18] [Security Solution] Update prebuilt rule customization UI copy (#210817) #211878

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.18:

Questions ?

Please refer to the Backport tool documentation

…ic#210817)

**Resolves: elastic/security-docs#6238
**Deployed here:
[link](https://nikitaindik-pr-210817-prebuilt-rule-customization-update-ui.kbndev.co/app/security/rules/updates?rulesTable=(field:name,order:asc,searchTerm:'Shared%20Object%20Created%20or%20Changed%20by%20Previously%20Unknown%20Process')&sourcerer=(default:(id:security-solution-default,selectedPatterns:!()))&timerange=(global:(linkTo:!(timeline),timerange:(from:'2025-02-11T23:00:00.000Z',fromStr:now/d,kind:absolute,to:'2025-02-12T22:59:59.999Z',toStr:now/d)),timeline:(linkTo:!(global),timerange:(from:'2025-02-11T23:00:00.000Z',fromStr:now/d,kind:absolute,to:'2025-02-12T22:59:59.999Z',toStr:now/d)))&timeline=(activeTab:query,graphEventId:'',isOpen:!f))**

> ⚠️ CI fails are caused by an issue unrelated to this PR

## Summary

Changes in this PR:
- UI copy is updated in accordance with
[recommendations](https://docs.google.com/document/d/1Yl6DyN9pertqgB-iIKIEN3xdvlDM50oscJ00G-WwtyA/edit?tab=t.0)
(internal link) from Security Documentation team
- Text color for "No update" fields in upgrade flyout changed from green
to default.
- Fixed a minor bug with placeholder not displaying for "Setup guide"
and "Investigation guide" fields on Rule Creation/Editing page

<details>
<summary><strong>A few screenshots taken in Serverless</strong> (click
to expand)</summary>

<img width="523" alt="serverless_rep_tooltip"
src="https://github.com/user-attachments/assets/825e1514-a191-45c2-90ca-0f15a8c9da7b"
/>

<img width="836" alt="serverless_bulk_action_error"
src="https://github.com/user-attachments/assets/8aa38c77-5aaa-49cf-9b4e-8c992382a1d2"
/>

<img width="1102" alt="serverless_upgrade_callout"
src="https://github.com/user-attachments/assets/cf947c73-d52d-4c85-abd6-369f616b8421"
/>

<img width="1004" alt="no_update_white"
src="https://github.com/user-attachments/assets/f720f24c-0c97-432f-b2d5-7ff7e5919ba0"
/>

</details>

## Testing
You can use [this
deployment](https://nikitaindik-pr-210817-prebuilt-rule-customization-update-ui.kbndev.co)
(default credentials) test to changes on ESS Enterprise license.
Here's a couple rules that has field updates of different kinds:
 - Unusual User Privilege Enumeration via id
 - Shared Object Created or Changed by Previously Unknown Process

To test on Serverless or with other licenses, you'll need to run it
locally. Reach out to me if you need help with this.

Work started: 11-Feb-2025

(cherry picked from commit 994201c)
@kibanamachine kibanamachine merged commit 71a86f8 into elastic:8.18 Feb 20, 2025
12 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.1MB 9.1MB +1.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolutionEss 12.5KB 13.0KB +481.0B
securitySolutionServerless 29.7KB 30.3KB +548.0B
total +1.0KB

cc @nikitaindik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants