[Obs AI Assistant] Remove TokenCountEvent #209549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorenlouv
commented
Feb 4, 2025
Comment on lines
-80
to
+76
| withLatestFrom(withoutTokenCount$), | ||
| withLatestFrom(shared.pipe(filterChunkEvents())), |
There was a problem hiding this comment.
Do we still need this? I think so but the previous naming was confusing.
|
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
dgieselaar
reviewed
Feb 4, 2025
x-pack/platform/plugins/shared/observability_ai_assistant/server/routes/runtime_types.ts
Outdated
Show resolved
Hide resolved
sorenlouv
added
backport:prev-minor
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
dgieselaar
reviewed
Feb 20, 2025
| nextEvents$, | ||
| title$.pipe(filter((value): value is TokenCountEvent => typeof value !== 'string')) | ||
| ).pipe(extractTokenCount()), | ||
| nextEvents$.pipe(extractMessages()), |
dgieselaar
approved these changes
Feb 20, 2025
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Public APIs missing exports
Page load bundle
History
|
|
Starting backport for target branches: 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 20, 2025
Closes elastic#205479 This filters out the `ChatCompletionTokenCountEvent` from the inference plugin. This greatly simplifies handling ChatCompletion events in the Obs AI Assistant. (cherry picked from commit c4826bd)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 20, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [[Obs AI Assistant] Remove TokenCountEvent (#209549)](#209549) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Søren Louv-Jansen","email":"soren.louv@elastic.co"},"sourceCommit":{"committedDate":"2025-02-20T17:59:19Z","message":"[Obs AI Assistant] Remove TokenCountEvent (#209549)\n\nCloses https://github.com/elastic/kibana/issues/205479\n\nThis filters out the `ChatCompletionTokenCountEvent` from the inference\nplugin. This greatly simplifies handling ChatCompletion events in the\nObs AI Assistant.","sha":"c4826bdfbfb88a31b455d2647e0268f8ffb4299f","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","Team:Obs AI Assistant","ci:project-deploy-observability","v9.1.0"],"title":"[Obs AI Assistant] Remove TokenCountEvent","number":209549,"url":"https://github.com/elastic/kibana/pull/209549","mergeCommit":{"message":"[Obs AI Assistant] Remove TokenCountEvent (#209549)\n\nCloses https://github.com/elastic/kibana/issues/205479\n\nThis filters out the `ChatCompletionTokenCountEvent` from the inference\nplugin. This greatly simplifies handling ChatCompletion events in the\nObs AI Assistant.","sha":"c4826bdfbfb88a31b455d2647e0268f8ffb4299f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209549","number":209549,"mergeCommit":{"message":"[Obs AI Assistant] Remove TokenCountEvent (#209549)\n\nCloses https://github.com/elastic/kibana/issues/205479\n\nThis filters out the `ChatCompletionTokenCountEvent` from the inference\nplugin. This greatly simplifies handling ChatCompletion events in the\nObs AI Assistant.","sha":"c4826bdfbfb88a31b455d2647e0268f8ffb4299f"}}]}] BACKPORT--> Co-authored-by: Søren Louv-Jansen <soren.louv@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #205479
This filters out the
ChatCompletionTokenCountEventfrom the inference plugin. This greatly simplifies handling ChatCompletion events in the Obs AI Assistant.