Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.18] [Data Streams] Unskip API integration tests (#209102) #209362

Closed
wants to merge 1 commit into from
Closed

[8.18] [Data Streams] Unskip API integration tests (#209102) #209362

wants to merge 1 commit into from

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.18:

Questions ?

Please refer to the Backport tool documentation

@ElenaStoeva
[Data Streams] Unskip API integration tests (elastic#209102)
13fbae5 
Closes elastic#209014

## Summary

This PR unskips and updates the Data streams API integration tests to
reflect the recent changes to Elasticsearch
(elastic/elasticsearch#121049). Previously, the
`cluster.logsdb.enabled` setting was always `false` by default in
stateful Kibana. With the new changes, it is `true` by default if the
`logsdb.prior_logs_usage` setting is `false` (which is the case for new
test clusters, hence the test failure), and `true` otherwise. Therefore,
we need to update the tests so that we test both cases.

Flaky test runner:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7821

(cherry picked from commit 96e3d55)
@kibanamachine kibanamachine enabled auto-merge (squash) February 3, 2025 16:33
@kibanamachine kibanamachine mentioned this pull request Feb 3, 2025
Merged
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 3, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #82 / management index management Data streams Get index mode index mode of logs-- data streams returns logsdb index mode if logsdb.enabled setting is null and logs.prior_logs_usage is false
  • [job] [logs] FTR Configs #82 / management index management Data streams Get index mode index mode of logs-- data streams returns logsdb index mode if logsdb.enabled setting is null and logs.prior_logs_usage is false
  • [job] [logs] Jest Tests #4 / Use cases toast hook showSuccessAttach Toast content Calls the onViewCaseClick when clicked

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
@kbn/test-suites-xpack 745 746 +1

Total ESLint disabled count

id before after diff
@kbn/test-suites-xpack 770 771 +1

History

cc @ElenaStoeva

@ElenaStoeva
Copy link
Contributor

ElenaStoeva commented Feb 4, 2025 •
edited
Loading

Closing as this change should only be applied to 9.0 as this is where the Es change was added.

@ElenaStoeva ElenaStoeva closed this Feb 4, 2025
auto-merge was automatically disabled February 4, 2025 13:42

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@ElenaStoeva ElenaStoeva

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibanamachine @elasticmachine @ElenaStoeva