[Data Streams] Unskip API integration tests #209102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElenaStoeva
added
Feature:Index Management
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
SoniaSanzV
reviewed
Jan 31, 2025
There was a problem hiding this comment.
thank you for addressing it, @ElenaStoeva. Lgtm :)
But let's wait for CI and Flaky Test Runner to succeed before approving it.
| @@ -27,7 +27,7 @@ export default function ({ getService }: FtrProviderContext) { | |||
| } = datastreamsHelpers(getService); | |||
|
|
|||
| // Failing: See https://github.com/elastic/kibana/issues/209014 | |||
There was a problem hiding this comment.
[nit] can you remove this code comment now?
There was a problem hiding this comment.
Oops, thanks for catching this! Removed.
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7821[✅] x-pack/test/api_integration/apis/management/config.ts: 200/200 tests passed. |
|
@elasticmachine merge upstream |
SoniaSanzV
approved these changes
Feb 3, 2025
|
Starting backport for target branches: 8.18, 8.x, 9.0 |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
cc @ElenaStoeva |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 3, 2025
Closes elastic#209014 ## Summary This PR unskips and updates the Data streams API integration tests to reflect the recent changes to Elasticsearch (elastic/elasticsearch#121049). Previously, the `cluster.logsdb.enabled` setting was always `false` by default in stateful Kibana. With the new changes, it is `true` by default if the `logsdb.prior_logs_usage` setting is `false` (which is the case for new test clusters, hence the test failure), and `true` otherwise. Therefore, we need to update the tests so that we test both cases. Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7821 (cherry picked from commit 96e3d55)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 3, 2025
Closes elastic#209014 ## Summary This PR unskips and updates the Data streams API integration tests to reflect the recent changes to Elasticsearch (elastic/elasticsearch#121049). Previously, the `cluster.logsdb.enabled` setting was always `false` by default in stateful Kibana. With the new changes, it is `true` by default if the `logsdb.prior_logs_usage` setting is `false` (which is the case for new test clusters, hence the test failure), and `true` otherwise. Therefore, we need to update the tests so that we test both cases. Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7821 (cherry picked from commit 96e3d55)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 3, 2025
Closes elastic#209014 ## Summary This PR unskips and updates the Data streams API integration tests to reflect the recent changes to Elasticsearch (elastic/elasticsearch#121049). Previously, the `cluster.logsdb.enabled` setting was always `false` by default in stateful Kibana. With the new changes, it is `true` by default if the `logsdb.prior_logs_usage` setting is `false` (which is the case for new test clusters, hence the test failure), and `true` otherwise. Therefore, we need to update the tests so that we test both cases. Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7821 (cherry picked from commit 96e3d55)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 3, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [[Data Streams] Unskip API integration tests (#209102)](#209102) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Elena Stoeva","email":"59341489+ElenaStoeva@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-03T16:24:58Z","message":"[Data Streams] Unskip API integration tests (#209102)\n\nCloses https://github.com/elastic/kibana/issues/209014\r\n\r\n## Summary\r\n\r\nThis PR unskips and updates the Data streams API integration tests to\r\nreflect the recent changes to Elasticsearch\r\n(elastic/elasticsearch#121049). Previously, the\r\n`cluster.logsdb.enabled` setting was always `false` by default in\r\nstateful Kibana. With the new changes, it is `true` by default if the\r\n`logsdb.prior_logs_usage` setting is `false` (which is the case for new\r\ntest clusters, hence the test failure), and `true` otherwise. Therefore,\r\nwe need to update the tests so that we test both cases.\r\n\r\nFlaky test runner:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7821","sha":"96e3d55638502eb55cba8f8ab2b9152599eed5a1","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index Management","Team:Kibana Management","release_note:skip","v9.0.0","backport:prev-minor","v8.18.0","v9.1.0","v8.19.0"],"title":"[Data Streams] Unskip API integration tests","number":209102,"url":"https://github.com/elastic/kibana/pull/209102","mergeCommit":{"message":"[Data Streams] Unskip API integration tests (#209102)\n\nCloses https://github.com/elastic/kibana/issues/209014\r\n\r\n## Summary\r\n\r\nThis PR unskips and updates the Data streams API integration tests to\r\nreflect the recent changes to Elasticsearch\r\n(elastic/elasticsearch#121049). Previously, the\r\n`cluster.logsdb.enabled` setting was always `false` by default in\r\nstateful Kibana. With the new changes, it is `true` by default if the\r\n`logsdb.prior_logs_usage` setting is `false` (which is the case for new\r\ntest clusters, hence the test failure), and `true` otherwise. Therefore,\r\nwe need to update the tests so that we test both cases.\r\n\r\nFlaky test runner:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7821","sha":"96e3d55638502eb55cba8f8ab2b9152599eed5a1"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209102","number":209102,"mergeCommit":{"message":"[Data Streams] Unskip API integration tests (#209102)\n\nCloses https://github.com/elastic/kibana/issues/209014\r\n\r\n## Summary\r\n\r\nThis PR unskips and updates the Data streams API integration tests to\r\nreflect the recent changes to Elasticsearch\r\n(elastic/elasticsearch#121049). Previously, the\r\n`cluster.logsdb.enabled` setting was always `false` by default in\r\nstateful Kibana. With the new changes, it is `true` by default if the\r\n`logsdb.prior_logs_usage` setting is `false` (which is the case for new\r\ntest clusters, hence the test failure), and `true` otherwise. Therefore,\r\nwe need to update the tests so that we test both cases.\r\n\r\nFlaky test runner:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7821","sha":"96e3d55638502eb55cba8f8ab2b9152599eed5a1"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Elena Stoeva <59341489+ElenaStoeva@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #209014
Summary
This PR unskips and updates the Data streams API integration tests to reflect the recent changes to Elasticsearch (elastic/elasticsearch#121049). Previously, the
cluster.logsdb.enabledsetting was alwaysfalseby default in stateful Kibana. With the new changes, it istrueby default if thelogsdb.prior_logs_usagesetting isfalse(which is the case for new test clusters, hence the test failure), andtrueotherwise. Therefore, we need to update the tests so that we test both cases.Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7821