[Infra UI] Settings doesn't handle errors

[neptunian]

When selecting one of the settings registered using uiSettings, errors aren't handled if the request fails and instead a success message is shown and changes are not saved. In this case the user doesn't have the advanced settings privilege.

• Inputs for fields that are not accessible should be disabled. You can use the advancedSettings.save UI capability to test for this on the front end.
• Requests that fail should display the error

Screen.Recording.2024-08-07.at.12.29.39.PM.mov

Related:

• [Obs AI Assistant] Functional tests for AI Assistant and Settings  #189920 makes a change to useEditableSettings to surface errors that can be handled, which Infra doesn't seem to be handling as I tested on this branch.
• Granular Permissions for Advanced Settings in Kibana Plugins #189812 SharedUX team is looking into allowing Advanced Settings to be registered as a feature privilege that we could add to "all" (on a per plugin basis). Though errors should still be handled for requests that fail.

[elasticmachine]

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

[crespocarlos]

@roshan-elastic we need to prioritize this

[roshan-elastic]

Cheers @crespocarlos - put it v high on the backlog

[crespocarlos]

I wonder if we should hide settings from advance settings in this case.

[crespocarlos]

APM handles the error, but I think we should display a better message

Whatever we do here we should make sure it's consistent with APM

[smith]

Whatever we do here we should make sure it's consistent with APM

...and they both should be consistent with the global advanced settings page.

I wonder if we should hide settings from advance settings in this case.

It probably should disable them with a note, similar to when you use uiSettings.overrides in your kibana.yml:

[botelastic]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.