Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cyberarkpas] Clean up null handling, formatting #9182

Merged
merged 2 commits into from
Feb 19, 2024
Merged

[cyberarkpas] Clean up null handling, formatting #9182

merged 2 commits into from
Feb 19, 2024

Conversation

chrisberkhout
Copy link
Contributor

Proposed commit message

[cyberarkpas] Clean up null handling, formatting (#)

- Remove redundant quotes.
- Add space around conditional operator.
- Combine 'not null and is/not value' checks.
- Check for null before > operator.
- Combine 'is null or not contains' checks.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@chrisberkhout chrisberkhout added Team:Service-Integrations Label for the Service Integrations team Integration:cyberarkpas CyberArk Privileged Access Security bugfix Pull request that fixes a bug issue labels Feb 15, 2024
@chrisberkhout chrisberkhout self-assigned this Feb 15, 2024
@chrisberkhout chrisberkhout requested a review from a team as a code owner February 15, 2024 18:38
@chrisberkhout chrisberkhout mentioned this pull request Feb 15, 2024
Open
39 tasks
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
44.4% 44.4% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

cc @chrisberkhout

@chrisberkhout chrisberkhout merged commit 40d6ae5 into elastic:main Feb 19, 2024
5 checks passed
@chrisberkhout chrisberkhout deleted the cyberarkpas-null-handling branch February 19, 2024 11:06
@elasticmachine
Copy link

Package cyberarkpas - 2.19.3 containing this change is available at https://epr.elastic.co/search?package=cyberarkpas

gizas pushed a commit that referenced this pull request Mar 13, 2024
@chrisberkhout @gizas
[cyberarkpas] Clean up null handling, formatting (#9182)
c19eff0 
- Remove redundant quotes.
- Add space around conditional operator.
- Combine 'not null and is/not value' checks.
- Check for null before > operator.
- Combine 'is null or not contains' checks.
qcorporation pushed a commit that referenced this pull request Feb 3, 2025
@chrisberkhout @gizas
[cyberarkpas] Clean up null handling, formatting (#9182)
b2bf543 
- Remove redundant quotes.
- Add space around conditional operator.
- Combine 'not null and is/not value' checks.
- Check for null before > operator.
- Combine 'is null or not contains' checks.
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
@chrisberkhout @gizas
[cyberarkpas] Clean up null handling, formatting (#9182)
46721c6 
- Remove redundant quotes.
- Add space around conditional operator.
- Combine 'not null and is/not value' checks.
- Check for null before > operator.
- Combine 'is null or not contains' checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees

@chrisberkhout chrisberkhout

Labels
bugfix Pull request that fixes a bug issue Integration:cyberarkpas CyberArk Privileged Access Security Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisberkhout @elasticmachine @efd6