Skip to content

[EuiComboBox] Clear button alignment #8553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
acstll opened this issue Apr 4, 2025 · 2 comments · Fixed by #8610
Closed

[EuiComboBox] Clear button alignment #8553

acstll opened this issue Apr 4, 2025 · 2 comments · Fixed by #8610
Assignees
Labels
low hanging fruit An issue, often a bug, that is lower effort and clearly ought to be fixed

Comments

@acstll
Copy link
Contributor

acstll commented Apr 4, 2025

Is your feature request related to a problem? Please describe.

When the EuiComboBox has many selected values, the clear button can be hard to find because it's aligned center.

Describe the solution you'd like

Make the icon buttons top-aligned.

Additional context

Image

Here's a codesandbox with the change with some custom CSS.

We need to consider on other inputs as well, not only the combobox.

@acstll acstll added the low hanging fruit An issue, often a bug, that is lower effort and clearly ought to be fixed label Apr 4, 2025
@stratoula
Copy link
Contributor

We have aligned the button at the top in these files elastic/kibana#217132

@weronikaolejniczak
Copy link
Contributor

I'm reestimating this to 2. If the fix covered only the EuiComboBox, we could easily override and it'd be 1. If we are applying the fix globally, then we have to consider the impact, test different cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low hanging fruit An issue, often a bug, that is lower effort and clearly ought to be fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants