Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving from requirements.txt to poetry #204

Open
endorama opened this issue Jan 5, 2023 · 1 comment
Open

Moving from requirements.txt to poetry #204

endorama opened this issue Jan 5, 2023 · 1 comment

Comments

@endorama
Copy link
Member

endorama commented Jan 5, 2023

Describe the enhancement: Change dependency management to a solution that simplifies and enhance dependency management.

Describe a specific use case for the enhancement or feature: First let me say that I appreciate the current solution, it works and solves the basic need of the project.

I think we can improve on top of it to help streamline the development, in both onboarding and maintenance.

These are the drawbacks I see in the current implementation:

  • we need multiple requirements file based on the environment, this complicates the setup and maintenance; this would also prevent confusion like in Fix CI test errors #203 (comment)
  • there is no Python version requirement
  • pip freeze > requirements.txt makes more complex to update dependencies (and requires manual work to split dependencies in separate files)
  • there is no dependency integrity check (like package shasum checks)

Poetry would allow us to improve on the current situation on these 4 fronts.

@aspacca @girodav what do you think?

/cc @elastic/obs-cloud-monitoring

@aspacca
Copy link
Contributor

aspacca commented Jan 9, 2023

@endorama I'm good on this, we just need to be sure that we export to requirements.txt with poetry for sam build(https://github.com/elastic/elastic-serverless-forwarder/blob/main/.internal/aws/scripts/dist.sh#L78)

similar to what's done here: https://gist.github.com/jakebrinkmann/ccd3537a61894fb676b10fa50fc2f9a3#file-readme-md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants