-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logstash to serverless provider #1646
Conversation
cd45ec3
to
b87d4af
Compare
It's a mistake. So re referring for a review
dbaf50e
to
36dd626
Compare
36dd626
to
ec66b59
Compare
ec66b59
to
74abca7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just a suggestion for an error message.
Thanks @bhapas for adding Logstash into the Serverless provider!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like requiring client authentication is making this more complex. Do we require it?
@jsoriano
And agent fails to publish events to logstash
|
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
io.netty.handler.ssl.NotSslRecordException: not an SSL/TLS record
This error seems to indicate that the agent is not using SSL when trying to connect to Logstash.
So what seems to be happening here is that we just need to enable SSL in the output. This is implicitly happening when providing a client certificate, but should be also possible without it.
Could you try to enable SSL, without providing a client certificate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bhapas for all the investigation about SSL in the logstash output!
b33f1bd
to
3b5256c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overal, thanks! Added some small comments.
💚 Build Succeeded
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think that we can get rid of the method to update the output. If this is not possible, I am good to go with this.
Thanks!
Adds logstash service as an optional service to
serverless
provider.Few updates as part of this PR:
elastic-agent
client certificate that is used for communication between agent and logstash over ssl in serverless usingx509.ExtKeyUsageClientAuth
UpdateFleetOutput
function to be able to update logstash fleet output with agent ssl certificates as these are created after starting local services.pkcs8
format . Hence modifying them usingopenssl pkcs8 -inform PEM -in /usr/share/logstash/config/certs/key.pem -topk8 -nocrypt -outform PEM -out /usr/share/logstash/config/certs/logstash.pkcs8.key
Note: Testing logstash over ssl with agent in local elastic stack is out of scope of this PR. WIll fix that in a separate PR.
Reference issue - #1658
Output when logstash is enabled in serverless provider
System test output
Closes #1645