-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-fill album for artist and track (closes #88) #250
Conversation
@elamperti |
The alerts use a context, so you can dispatch messages easily. I think that, for this feature, perhaps it would be more appropriate to show a spinner within the input (when loading) and create a "shake" animation if there's a failure (or some other indicator around this field). |
Hmm, when I run OpenScrobbler locally, the catch-paste thing doesn't work. Anyway, I would be glad if you add this animation. I am really not a frontend guy. |
Sure! I'll look into it. To catch pasted text, you should have the corresponding option enabled (from the settings modal) |
Hi @elamperti |
Awesome! I'm a bit backed up with a few other upcoming changes but I'll review and merge as soon as possible. Thanks for your work and patience! 😁 |
Resolved conflict with the main branch in previous commit |
Thank you! I'm finishing with a few adjustments on #237 and I'll get to this one \o/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic! Great job adding the animation as well 😃
The feature uses last.fm API trackGetInfo to retrieve an album name based on track + artist.
To complete this, I'd ask for help with a couple of things:
Things to consider: rate-limit last.fm API calls? Delegate to backend?