Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding remote network config to private clusters #8261

Merged
merged 1 commit into from
Feb 27, 2025
+6 −10
Merged

Allow adding remote network config to private clusters #8261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions pkg/apis/eksctl.io/v1alpha5/validation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,14 +90,6 @@ func (c *ClusterConfig) validateRemoteNetworkingConfig() error {
return nil
}

if !IsEnabled(c.VPC.ClusterEndpoints.PublicAccess) {
return fmt.Errorf("remoteNetworkConfig requires public cluster endpoint access")
}

if c.IsFullyPrivate() {
return fmt.Errorf("remoteNetworkConfig is not supported on fully private EKS cluster")
}

if c.IPv6Enabled() {
return fmt.Errorf("remoteNetworkConfig is not supported on EKS cluster configured with IPv6 address family")
}
Expand Down
8 changes: 6 additions & 2 deletions pkg/apis/eksctl.io/v1alpha5/validation_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -993,16 +993,20 @@ var _ = Describe("ClusterConfig validation", func() {
cc.VPC.ClusterEndpoints = &api.ClusterEndpoints{
PublicAccess: api.Disabled(),
}
cc.RemoteNetworkConfig.IAM = &api.RemoteNodesIAM{
Provider: aws.String("BLOB"),
}
},
expectedErr: "remoteNetworkConfig requires public cluster endpoint access",
}),
Entry("fully private EKS cluster", remoteNetworkConfigEntry{
overrideConfig: func(cc *api.ClusterConfig) {
cc.PrivateCluster = &api.PrivateCluster{
Enabled: true,
}
cc.RemoteNetworkConfig.IAM = &api.RemoteNodesIAM{
Provider: aws.String("BLOB"),
}
},
expectedErr: "remoteNetworkConfig is not supported on fully private EKS cluster",
}),
Entry("IPv6 family", remoteNetworkConfigEntry{
overrideConfig: func(cc *api.ClusterConfig) {
Expand Down
Loading