Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding remote network config to private clusters #8261

Merged

Conversation

NicholasBlaskey
Copy link
Contributor

Description

Remove validation rules that prevented remote network config from being used with private clusters.

Tested manually that validation did not fail with privateCluster.enabled=true added to this file https://github.com/eksctl-io/eksctl/blob/main/examples/43-hybrid-nodes.yaml

Checklist

  • Added tests that cover your change (if possible)
  • [none required] Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello NicholasBlaskey 👋 Thank you for opening a Pull Request in eksctl project. The team will review the Pull Request and aim to respond within 1-10 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website

@NicholasBlaskey NicholasBlaskey marked this pull request as ready for review February 27, 2025 21:53
@gustavodiaz7722 gustavodiaz7722 self-assigned this Feb 27, 2025
@gustavodiaz7722 gustavodiaz7722 merged commit 5dd8d4c into eksctl-io:main Feb 27, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants