Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate/verify schema .. had forgotten to update schema.json for neuron devices #8255

Conversation

dims
Copy link
Contributor

@dims dims commented Feb 26, 2025

found via an integration test failure. we should flag this as quickly as possible, so added a generate/check make target so we don't get tripped up.

[0] Utils schema [It] displays the schema
[0] /__w/eksctl-ci/eksctl-ci/eksctl/integration/tests/utils/utils_test.go:30
[0] 
[0]   [FAILED] Expected
[0]       <string>: "...    "neuron..."
[0]   to equal               |
[0]       <string>: "...    "vCPUs"..."
[0]   In [It] at: /__w/eksctl-ci/eksctl-ci/eksctl/integration/tests/utils/utils_test.go:34 @ 02/26/25 19:19:50.931

…ron devices

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims enabled auto-merge (squash) February 26, 2025 20:15
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@dims dims merged commit 18bdfc3 into eksctl-io:main Feb 26, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants