Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix go.sum; check go.mod and go.sum on CI #8254

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Fix go.sum; check go.mod and go.sum on CI #8254

merged 1 commit into from
Feb 26, 2025
+7 −5

Conversation

alexandear
Copy link
Contributor

Description

Update go.sum by running go mod tidy; add make check-gomod to CI.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@dims dims merged commit 95ea496 into eksctl-io:main Feb 26, 2025
9 of 10 checks passed
@eksctl-bot eksctl-bot mentioned this pull request Feb 26, 2025
Open
@alexandear alexandear deleted the ci-go-mod-tidy branch February 26, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims approved these changes

Assignees
No one assigned
Labels
kind/improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandear @dims