-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Karpenter usage documentation to reflect latest supported version(s) #8250
Update Karpenter usage documentation to reflect latest supported version(s) #8250
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello escardoso 👋 Thank you for opening a Pull Request in eksctl
project. The team will review the Pull Request and aim to respond within 1-10 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl
on our website
@bryantbiggs , Thanks for the suggestions. Upload a new version with the requested corrections. |
@escardoso will this help folks who have run into other issues like #8198? |
@dims I think that is more of an issue here eksctl/pkg/utils/kubeconfig/kubeconfig.go Lines 34 to 39 in 1a596f9
Ref - aws/aws-cli#6940 tl;dr - we shouldn't be using |
@bryantbiggs you are right! we gotta fix that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @escardoso !
Description
The fields that referenced old versions of Karpenter have been changed. The links to the documentation have also been updated and examples of configuring the NodePool and EC2NodeClass files have been added in accordance with the new version of Karpenter v1.
Resolves #8227
Help your reviewers my guiding them through your key changes,
implementation decisions etc.
You can even include snippets of output or screenshots.
Checklist
README.md
, or theuserdocs
directory)area/nodegroup
) and kind (e.g.kind/improvement
)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯