Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Karpenter usage documentation to reflect latest supported version(s) #8250

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

escardoso
Copy link
Contributor

@escardoso escardoso commented Feb 25, 2025

Description

The fields that referenced old versions of Karpenter have been changed. The links to the documentation have also been updated and examples of configuring the NodePool and EC2NodeClass files have been added in accordance with the new version of Karpenter v1.

Resolves #8227

Help your reviewers my guiding them through your key changes,
implementation decisions etc.

You can even include snippets of output or screenshots.

Screenshot 2025-02-25 at 11 28 35

Screenshot 2025-02-25 at 11 31 04

Screenshot 2025-02-25 at 11 31 36

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello escardoso 👋 Thank you for opening a Pull Request in eksctl project. The team will review the Pull Request and aim to respond within 1-10 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website

@bryantbiggs bryantbiggs changed the title update karpenter version on Karpenter Support Update Karpenter usage documentation to reflect latest supported version(s) Feb 25, 2025
@escardoso
Copy link
Contributor Author

@bryantbiggs , Thanks for the suggestions. Upload a new version with the requested corrections.

@dims
Copy link
Contributor

dims commented Feb 25, 2025

@escardoso will this help folks who have run into other issues like #8198?

@bryantbiggs
Copy link
Member

@dims I think that is more of an issue here

AWSCLIv1MinimumBetaVersion = "1.23.9"
// AWSCLIv2MinimumBetaVersion this is the minimum version at which aws-cli v2 uses v1beta1 as APIVersion
AWSCLIv2MinimumBetaVersion = "2.6.3"
alphaAPIVersion = "client.authentication.k8s.io/v1alpha1"
betaAPIVersion = "client.authentication.k8s.io/v1beta1"

Ref - aws/aws-cli#6940
Ref - aws/aws-cli#6476

tl;dr - we shouldn't be using client.authentication.k8s.io/v1alpha1 anymore

@dims
Copy link
Contributor

dims commented Feb 25, 2025

@bryantbiggs you are right! we gotta fix that

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @escardoso !

@bryantbiggs bryantbiggs merged commit 13d3635 into eksctl-io:main Feb 25, 2025
11 checks passed
@escardoso escardoso deleted the update-eksctl-karpenter-md branch February 25, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/karpenter kind/docs User documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Docs have very old, invalid info for Karpenter
3 participants