Add support for allow/deny regexp(s) in instanceSelector #8247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: #3718
It is useful to have expose
allow
anddeny
functionality already inec2-instance-selector
as i don't see any other helpful feature/future suggestions in #3718 are happening anytime soon.Tested with the following config by hand in addition to the test case:
without any allow/deny statements you will see following
instanceTypes
:then added various combinations of
allow
anddeny
to make sure the list of instance types matches what is expected.example: