GPUs != Neuron Devices (when it comes to instance selector) #8243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ec2-instance-selector has a totally different option for Neuron Devices ( https://github.com/search?q=repo%3Aaws%2Famazon-ec2-instance-selector+accelerators&type=code ).
So the
gpus
field ininstanceSelector
does NOT cover Neuron Devices. For example if you saygpus: 0
you may still get an instance type with a neuron device/accelerator.To explicitly specify the number of neuron devices you need to add another field
neuron_devices
for example see:There was a bug in ec2-instance-selector as well in the accelerator selection, which has been fixed and picked up in this PR