Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove intermediate build image from add-on auto-update CI workflow #8234

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

bryantbiggs
Copy link
Member

Description

  • Remove intermediate build image from add-on auto-update CI workflow

To fix errors https://github.com/eksctl-io/eksctl/actions/runs/13447980212/job/37577239833

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@bryantbiggs bryantbiggs added kind/bug area/add-ons skip-release-notes Causes PR not to show in release notes labels Feb 21, 2025
@bryantbiggs bryantbiggs force-pushed the fix/addon-auto-update-ci branch from ebe120d to 289305b Compare February 21, 2025 01:35
@bryantbiggs
Copy link
Member Author

Validated here https://github.com/eksctl-io/eksctl/actions/runs/13448192026 - CI is back running green again using this branch

@bryantbiggs bryantbiggs requested a review from dims February 21, 2025 01:39
@bryantbiggs bryantbiggs enabled auto-merge (squash) February 21, 2025 01:42
Copy link
Contributor

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bryantbiggs bryantbiggs merged commit 99da5cb into main Feb 22, 2025
12 checks passed
@bryantbiggs bryantbiggs deleted the fix/addon-auto-update-ci branch February 22, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/add-ons kind/bug skip-release-notes Causes PR not to show in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants