Re-add support for env var keys from AWS SDK #8231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
|
cc @bryantbiggs |
bryantbiggs
approved these changes
Feb 20, 2025
|
xref: #7968 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We dropped support for
AWS_ENDPOINT_URLandAWS_ENDPOINT_URL_*environment vars that are documented here in commit e64db43:We are not going back to honoring what is in the shared config files, but
AWS_ENDPOINT_URLitself is a handy short-cut for sure.In this PR, we will explicitly list all the env vars that we support, loop through them (in a specific order) and use whichever is defined.
xref: #8231