Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update attributions document #8214

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Update attributions document #8214

merged 1 commit into from
Feb 13, 2025

Conversation

cheeseandcereal
Copy link
Member

Description

Re-running attribution-gen to update the attributions document.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@cheeseandcereal cheeseandcereal added the skip-release-notes Causes PR not to show in release notes label Feb 13, 2025
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - I'll leave it up to you if you want to add this file to the ignore list from the link checker in order to make that CI check green

args: --exclude-all-private --exclude-mail --exclude-file .github/workflows/exclude-file.txt --exclude-path goformation --verbose --no-progress './**/*.md' './**/*.html'

Signed-off-by: Adam Crowder <adam@adamcrowder.net>
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cheeseandcereal
Copy link
Member Author

looks good - I'll leave it up to you if you want to add this file to the ignore list from the link checker in order to make that CI check green

args: --exclude-all-private --exclude-mail --exclude-file .github/workflows/exclude-file.txt --exclude-path goformation --verbose --no-progress './**/*.md' './**/*.html'

This was actually only failing because main was failing at the time. The whole --exclude-file directive is deprecated, so that whole link checker action probably needs to be updated. We should do that separately, I think

@cheeseandcereal cheeseandcereal merged commit 3fb1a7a into main Feb 13, 2025
10 checks passed
@cheeseandcereal cheeseandcereal deleted the update-attributions branch February 13, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-release-notes Causes PR not to show in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants