Skip to content

Commit

Permalink
Remove unnecessary check for oidc provider during cluster creation
Browse files Browse the repository at this point in the history
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
  • Loading branch information
dims committed Feb 25, 2025
1 parent 2eee4c4 commit ae4f37c
Showing 1 changed file with 5 additions and 9 deletions.
14 changes: 5 additions & 9 deletions pkg/actions/addon/tasks.go
Original file line number Diff line number Diff line change
Expand Up @@ -178,15 +178,11 @@ func createAddonManager(ctx context.Context, clusterProvider *eks.ClusterProvide
oidcProviderExists bool
)
if api.IsEnabled(cfg.IAM.WithOIDC) {
var err error
oidc, err = clusterProvider.NewOpenIDConnectManager(ctx, cfg)
if err != nil {
return nil, err
}
oidcProviderExists, err = oidc.CheckProviderExists(ctx)
if err != nil {
return nil, err
}
// We are here because we are creating a cluster with OIDC enabled.
// To avoid a race, assume that it is getting created properly
// and do not check explicitly if it is already ready. If we really
// want to be sure then we would have to loop/wait/timeout here.
oidcProviderExists = true
}

stackManager := clusterProvider.NewStackManager(cfg)
Expand Down

0 comments on commit ae4f37c

Please sign in to comment.