Implement pinned (sticky) header and footer #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heoblitz
changed the title
heoblitz
commented
Oct 25, 2024
| @@ -619,7 +627,7 @@ open class CollectionViewChatLayout: UICollectionViewLayout { | |||
| || (isUserInitiatedScrolling && state == .beforeUpdate) | |||
|
|
|||
| invalidationActions.remove(.shouldInvalidateOnBoundsChange) | |||
| return shouldInvalidateLayout | |||
| return shouldInvalidateLayout || hasPinnedHeaderOrFooter | |||
There was a problem hiding this comment.
Ensure that the footer and header are properly updated when the bounds change, in the same way as in MagazineLayout.
( The default behavior of UICollectionViewCompositionalLayout also always returns true when section pinToVisibleBounds is set. )
heoblitz
force-pushed
the
feature/pinned_header_footer
branch
from
5791b05 to
9fdab05
Compare
|
@heoblitz Amazing job. Ill have a proper look and merge. Thank you. |
|
@heoblitz Sorry, I was on my vacation. Got back. Will have a proper look and merge. |
|
@ekazaev Hope you had a great vacation! Please feel free to review it at your convenience. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR introduces support for pinned (sticky) headers and footers. The implementation allows headers and footers to stay visible within the collection view's bounds.
The changes will not impact existing ChatLayout users who do not utilize the pinned feature.
Related PR: airbnb/MagazineLayout#52
Tests
test project: ChatLayoutPinTest.zip
1. Scroll
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-10-25.at.22.24.45.mp4
2. Scroll with contentInsets
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-10-25.at.22.30.31.mp4
3. Dynamic cell height
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-10-25.at.22.26.14.mp4