Skip to content

Commit

Permalink
Improve error message.
Browse files Browse the repository at this point in the history
Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>
  • Loading branch information
ejortegau committed Oct 22, 2024
1 parent d7b8ddd commit 2d22cf4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion go/vt/vtctl/reparentutil/emergency_reparenter.go
Original file line number Diff line number Diff line change
Expand Up @@ -762,7 +762,7 @@ func (erp *EmergencyReparenter) filterValidCandidates(validTablets []*topodatapb
if ok && backingUp {
erp.logger.Infof("Removing %s from list of valid candidates for promotion because it is running a backup", tabletAliasStr)
if opts.NewPrimaryAlias != nil && topoproto.TabletAliasEqual(opts.NewPrimaryAlias, tablet.Alias) {
return nil, vterrors.Errorf(vtrpc.Code_ABORTED, "proposed primary %s will not be able to make forward progress on being promoted", topoproto.TabletAliasString(opts.NewPrimaryAlias))
return nil, vterrors.Errorf(vtrpc.Code_ABORTED, "proposed primary %s is taking backup, refusing to promote it", topoproto.TabletAliasString(opts.NewPrimaryAlias))
}
continue
}
Expand Down

0 comments on commit 2d22cf4

Please sign in to comment.